WZhuo commented on code in PR #590:
URL: https://github.com/apache/iceberg-cpp/pull/590#discussion_r2964465478
##########
src/iceberg/table_scan.h:
##########
@@ -373,6 +383,26 @@ class ICEBERG_EXPORT IncrementalScan : public TableScan {
using TableScan::TableScan;
};
+// Template method implementation (must be in header for MSVC)
+template <typename ScanTaskType>
+Result<std::vector<std::shared_ptr<ScanTaskType>>>
+IncrementalScan<ScanTaskType>::PlanFiles() const {
+ if (context_.IsScanCurrentLineage()) {
+ ICEBERG_ASSIGN_OR_RAISE(auto current_snapshot, metadata_->Snapshot());
Review Comment:
If `current_snapshot` is nullptr, it indicates that the current table is
empty, so we can simply return an empty task list. No need care about the
`branch`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
