laskoviymishka commented on code in PR #789: URL: https://github.com/apache/iceberg-go/pull/789#discussion_r2977496516
########## table/row_delta.go: ########## @@ -0,0 +1,185 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package table + +import ( + "context" + "errors" + "fmt" + + "github.com/apache/iceberg-go" + iceio "github.com/apache/iceberg-go/io" +) + +// RowDelta encodes a set of row-level changes to a table: new data files +// (inserts) and delete files (equality or position deletes). All changes +// are committed atomically in a single snapshot. +// +// The operation type of the produced snapshot is determined automatically: +// - Data files only → OpAppend +// - Delete files only → OpDelete +// - Both data and delete files → OpOverwrite +// +// This matches the semantics of Java's BaseRowDelta. It is the primary +// API for CDC/streaming workloads where INSERTs, UPDATEs, and DELETEs +// must be committed together. +// +// Note: conflict detection for concurrent writers is not yet implemented. +// Concurrent RowDelta commits against the same table may produce incorrect +// results if delete files miss newly appended data. For single-writer +// workloads this is safe. +// +// Usage: +// +// rd := tx.NewRowDelta(snapshotProps) +// rd.AddRows(dataFile1, dataFile2) +// rd.AddDeletes(equalityDeleteFile1) +// err := rd.Commit(ctx) +type RowDelta struct { + txn *Transaction + dataFiles []iceberg.DataFile + delFiles []iceberg.DataFile + props iceberg.Properties +} + +// NewRowDelta creates a new RowDelta for committing row-level changes +// within this transaction. The provided properties are included in the +// snapshot summary. +func (t *Transaction) NewRowDelta(snapshotProps iceberg.Properties) *RowDelta { + return &RowDelta{ + txn: t, + props: snapshotProps, + } +} Review Comment: it's kinda separate thing, since its' a fabric method for row-delta i put it there, but have no strong opinion -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
