swapna267 commented on PR #15471: URL: https://github.com/apache/iceberg/pull/15471#issuecomment-4114688122
We would need to support all following configs to be configurable from SQL for dynamic sink. Few already are part of Writeoptions, 1. overwrite(boolean) → FlinkWriteOptions.OVERWRITE_MODE 2. writeParallelism(int) → FlinkWriteOptions.WRITE_PARALLELISM 3. distributionMode -> FlinkWriteOptions.DISTRIBUTION_MODE 4. toBranch(String) → FlinkWriteOptions.BRANCH Will move the following to DynamicSinkOptions cacheMaxSize(int) → FlinkWriteOptions.CACHE_MAX_SIZE Will create all following one's in DynamicSinkOptions 6. immediateTableUpdate(boolean) 7. dropUnusedColumns(boolean) 8. cacheRefreshMs(long) 9. inputSchemasPerTableCacheMaxSize(int) 10. caseSensitive(boolean) Will create separate PR to make above changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
