findinpath commented on code in PR #15734:
URL: https://github.com/apache/iceberg/pull/15734#discussion_r2979115572
##########
gcp/src/main/java/org/apache/iceberg/gcp/gcs/GCSInputFile.java:
##########
@@ -93,6 +94,9 @@ public SeekableInputStream newStream() {
private SeekableInputStream newGoogleCloudStorageInputStream() throws
IOException {
if (null == blobSize) {
+ if (storage().get(blobId()) == null) {
Review Comment:
> doesn't this add an additional request for every input stream?
Indeed it does.
The alternative would be to catch a lower-level `404` storage exception
while reading.
I'll reshape the code to contain this handling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
