jbonofre commented on code in PR #15212: URL: https://github.com/apache/iceberg/pull/15212#discussion_r2989127329
########## site/docs/how-to-release.md: ########## @@ -297,6 +302,22 @@ Java artifacts are available from Maven Central. Thanks to everyone for contributing! ``` +#### Confluent Marketplace Submission + +After the release is published to Maven Central, the Kafka Connect runtime distribution +can be [submitted to](https://docs.confluent.io/platform/current/connect/confluent-hub/contributing.html) +[Confluent Marketplace](https://www.confluent.io/hub/) for broader distribution. + +To submit to Confluent Hub: + +1. [Contact the Confluent Hub team](mailto:[email protected]) with the Maven Central URL for the distribution zip: + + ``` + https://repo1.maven.org/maven2/org/apache/iceberg/iceberg-kafka-connect-runtime/<VERSION>/iceberg-kafka-connect-runtime-<VERSION>.zip Review Comment: For the record, in `kafka-connect/build.gradle` (line 238-240), we can see: ``` // there are no Maven artifacts so disable publishing tasks... project.afterEvaluate { project.tasks.matching { it.group == 'publishing' }.each {it.enabled = false} } ``` We can give link to Maven Central, but we can also completely publish the kafka-connect-runtime distribution on dist.apache.org (stage and then release), and give access via downloads.apache.org. That's completely a viable option. ########## site/docs/how-to-release.md: ########## @@ -297,6 +302,22 @@ Java artifacts are available from Maven Central. Thanks to everyone for contributing! ``` +#### Confluent Marketplace Submission Review Comment: So, I took a deeper look on this. I think we are fine here: according to line 316(in this file), we are publishing (on Confluent Marketplace) a kafka-runtime distribution (main) that has been reviewed/voted as part of a release. So it means that the "legal checks" should have been done as part of the release. So, we are taking the kafka connect runtime distribution from Maven Central to "cross" publish on Confluent Marketplace. However, we have a prerequisite here: we never published the kafka-connect-runtime distribution up to now. So, it means that we have to include kafka-connect-runtime distribution as part of the release process (stage on dist.apache.org for review, and stage on repository.apache.org). It's not directly related to this PR, but it's a prerequisite. ########## site/docs/how-to-release.md: ########## @@ -297,6 +302,22 @@ Java artifacts are available from Maven Central. Thanks to everyone for contributing! ``` +#### Confluent Marketplace Submission Review Comment: What alternatives do we have ? I'm fine to ask the release manager to email Confluent for publication as soon as the kafka-connect-runtime has been reviewed and voted as part of an official release. According to line 316, we are "publishing" on Confluent a distribution that has been voted (as part of an official release). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
