kinolaev commented on code in PR #15713: URL: https://github.com/apache/iceberg/pull/15713#discussion_r2989228952
########## core/src/main/java/org/apache/iceberg/ManifestFilterManager.java: ########## Review Comment: `filterManifestWithDeletedFiles` is called only in `filterManifest`, where `reader` is already wrapped with try-with-resources. So it doesn't cause any issue. But if you'd like I can wrap this liveEntries() call too, just in case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
