emkornfield commented on code in PR #15283:
URL: https://github.com/apache/iceberg/pull/15283#discussion_r2990947505
##########
kafka-connect/kafka-connect/src/test/java/org/apache/iceberg/connect/data/TestRecordConverter.java:
##########
@@ -881,6 +888,203 @@ public void testEvolveTypeDetectionStructNested() {
assertThat(updateMap.get("st.ff").type()).isInstanceOf(DoubleType.class);
}
+ private RecordConverter variantConverter() {
+ Table table = mock(Table.class);
+ when(table.schema()).thenReturn(VARIANT_SCHEMA);
+ return new RecordConverter(table, config);
+ }
+
+ @Test
+ public void testConvertVariantValueFromNull() {
+ Variant variant = variantConverter().convertVariantValue(null);
+ assertThat(variant).isNotNull();
+ assertThat(variant.value().type()).isEqualTo(PhysicalType.NULL);
+ }
+
+ @Test
+ public void testConvertVariantValueFromPrimitiveString() {
+ Variant variant = variantConverter().convertVariantValue("hello");
+ assertThat(variant).isNotNull();
+ assertThat(variant.metadata()).isNotNull();
+ assertThat(variant.metadata().dictionarySize()).isEqualTo(0);
+ assertThat(variant.value().type()).isEqualTo(PhysicalType.STRING);
+ assertThat(variant.value().asPrimitive().get()).isEqualTo("hello");
+ }
+
+ @Test
+ public void testConvertVariantValueFromPrimitiveNumber() {
+ Variant variant = variantConverter().convertVariantValue(123);
+ assertThat(variant).isNotNull();
+ assertThat(variant.metadata().dictionarySize()).isEqualTo(0);
+ assertThat(variant.value().type()).isEqualTo(PhysicalType.INT32);
+ assertThat(variant.value().asPrimitive().get()).isEqualTo(123);
+ }
+
+ @Test
+ public void testConvertVariantValueFromBoolean() {
+ Variant variant = variantConverter().convertVariantValue(true);
+ assertThat(variant).isNotNull();
+ assertThat(variant.value().type()).isEqualTo(PhysicalType.BOOLEAN_TRUE);
+ assertThat(variant.value().asPrimitive().get()).isEqualTo(true);
+ }
+
+ @Test
+ public void testConvertVariantValueFromList() {
+ Variant variant =
variantConverter().convertVariantValue(ImmutableList.of("hello", 1));
+ assertThat(variant).isNotNull();
+ assertThat(variant.metadata().dictionarySize()).isEqualTo(0);
+ assertThat(variant.value().type()).isEqualTo(PhysicalType.ARRAY);
+ assertThat(variant.value().asArray().numElements()).isEqualTo(2);
+
assertThat(variant.value().asArray().get(0).asPrimitive().get()).isEqualTo("hello");
+
assertThat(variant.value().asArray().get(1).asPrimitive().get()).isEqualTo(1);
+ }
+
+ @Test
+ public void testConvertVariantValueFromListWithMixedTypes() {
+ // array with heterogeneous element types (string, int, boolean, double,
null)
+ // Note: java.util.Date is not supported in variant conversion; use
supported types only.
+ List<Object> input = Lists.newArrayList("a", 1, true, 2.5, null);
+ Variant variant = variantConverter().convertVariantValue(input);
+
+ assertThat(variant).isNotNull();
+ assertThat(variant.value().type()).isEqualTo(PhysicalType.ARRAY);
+ assertThat(variant.value().asArray().numElements()).isEqualTo(5);
+
+
assertThat(variant.value().asArray().get(0).type()).isEqualTo(PhysicalType.STRING);
+
assertThat(variant.value().asArray().get(0).asPrimitive().get()).isEqualTo("a");
+
+
assertThat(variant.value().asArray().get(1).type()).isEqualTo(PhysicalType.INT32);
+
assertThat(variant.value().asArray().get(1).asPrimitive().get()).isEqualTo(1);
+
+
assertThat(variant.value().asArray().get(2).type()).isEqualTo(PhysicalType.BOOLEAN_TRUE);
+
assertThat(variant.value().asArray().get(2).asPrimitive().get()).isEqualTo(true);
+
+
assertThat(variant.value().asArray().get(3).type()).isEqualTo(PhysicalType.DOUBLE);
+
assertThat(variant.value().asArray().get(3).asPrimitive().get()).isEqualTo(2.5);
+
+
assertThat(variant.value().asArray().get(4).type()).isEqualTo(PhysicalType.NULL);
+ }
+
+ @Test
+ public void testConvertVariantValueFromMap() {
+ Variant variant =
variantConverter().convertVariantValue(ImmutableMap.of("hello", 1));
Review Comment:
should we have multiple value types? Also we should make sure we test the
case when the key is null or not a string.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
