findinpath commented on code in PR #9830:
URL: https://github.com/apache/iceberg/pull/9830#discussion_r2991313329
##########
api/src/main/java/org/apache/iceberg/view/ViewBuilder.java:
##########
@@ -19,6 +19,7 @@
package org.apache.iceberg.view;
import java.util.Map;
+import org.apache.iceberg.catalog.TableIdentifier;
Review Comment:
Can you pls add in `CatalogHandlers.java`
```
public static LoadViewResponse createView(
ViewCatalog catalog, Namespace namespace, CreateViewRequest request) {
request.validate();
ViewBuilder viewBuilder =
catalog
.buildView(TableIdentifier.of(namespace, request.name()))
.withSchema(request.schema())
.withProperties(request.properties())
.withDefaultNamespace(request.viewVersion().defaultNamespace())
.withDefaultCatalog(request.viewVersion().defaultCatalog())
.withLocation(request.location())
// this is the new line to be added
.withStorageTableIdentifier(request.viewVersion().storageTable());
....
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]