wypoon commented on code in PR #15767:
URL: https://github.com/apache/iceberg/pull/15767#discussion_r2991328930
##########
core/src/main/java/org/apache/iceberg/SchemaUpdate.java:
##########
@@ -715,7 +714,7 @@ public Type map(Types.MapType map, Type kResult, Type
valueResult) {
// if any updates are intended for the key, throw an exception
int keyId = map.fields().get(0).fieldId();
if (deletes.contains(keyId)) {
- throw new IllegalArgumentException("Cannot delete map keys: " + map);
+ throw new IllegalArgumentException("Cannot delete key type from map: "
+ map);
Review Comment:
I suggest not changing the message in the exception. Otherwise, to be
consistent, you should change the message in the other exceptions in this
method too (e.g., "Cannot update key type in map: ...").
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
