rdblue commented on a change in pull request #1825:
URL: https://github.com/apache/iceberg/pull/1825#discussion_r533019831
##########
File path: nessie/src/test/java/org/apache/iceberg/nessie/TestNessieTable.java
##########
@@ -325,7 +325,7 @@ private static String addRecordsToFile(Table table, String
filename) throws IOEx
String fileLocation = table.location().replace("file:", "") +
String.format("/data/%s.avro", filename);
try (FileAppender<GenericData.Record> writer =
Avro.write(Files.localOutput(fileLocation))
- .schema(schema)
+ .schema(SCHEMA)
Review comment:
In the future, let's separate style changes from behavior or features.
It's okay now because this is unreleased so no one is submitting patches or
cherry-picking into a branch. But in the future we prefer to avoid commit
conflicts by keeping PR changes small and focused.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
