RussellSpitzer commented on code in PR #15634:
URL: https://github.com/apache/iceberg/pull/15634#discussion_r2996258635
##########
core/src/test/java/org/apache/iceberg/TestBase.java:
##########
@@ -472,6 +487,16 @@ Snapshot apply(SnapshotUpdate<?> snapshotUpdate, String
branch) {
}
void validateSnapshot(Snapshot old, Snapshot snap, Long sequenceNumber,
DataFile... newFiles) {
+ validateSnapshot(table, old, snap, sequenceNumber, newFiles);
+ }
+
+ @SuppressWarnings("checkstyle:HiddenField")
+ void validateSnapshot(
Review Comment:
We had to do some changes here but it wasn't actually related to V4 but was
exposed by the "missing partition spec" field.
Basically we had some tests like
TestReplacePartitions
That would validate against the wrong table but it happened to work because
AVRO didn't care if the "SPEC" information was incorrect, it would just go
ahead and read the manifests. With Parquet there is now a missing field if the
table is unpartitioned so you get an actual read error when you validate with
the wrong table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
