stevenzwu commented on code in PR #15746:
URL: https://github.com/apache/iceberg/pull/15746#discussion_r2997643966
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -162,6 +162,8 @@ paths:
$ref: '#/components/responses/UnauthorizedResponse'
403:
$ref: '#/components/responses/ForbiddenResponse'
+ 404:
+ $ref: '#/components/responses/NoSuchWarehouseResponse'
Review Comment:
I also think 404 may not be the best fit, as it generally indicates that the
endpoint itself could not be found. The endpoint receiving the query parameters
does exist, and a lack of results is a valid outcome of the search/filter
operation, not a client error in forming the request URI.
Maybe return 204 No Content as the request itself was valid and successfully
processed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
