stevenzwu commented on code in PR #15788:
URL: https://github.com/apache/iceberg/pull/15788#discussion_r3001938328


##########
.github/workflows/open-api.yml:
##########
@@ -45,8 +45,12 @@ jobs:
 
     steps:
       - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
+        with:
+          persist-credentials: false
       - name: Install uv
         uses: astral-sh/setup-uv@5a095e7a2014a4212f075830d4f7277575a9d098
+        with:
+          enable-cache: false

Review Comment:
   this seems fine. open-api workflow runs in ~22s per CI check. So the 
performance gain from caching is probably not that important. This is simpler 
and secure.
   
   We can add back cache/restore in the future if this workflow becomes a 
bottleneck.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to