kevinjqliu commented on code in PR #15794:
URL: https://github.com/apache/iceberg/pull/15794#discussion_r3002627016
##########
.github/workflows/labeler.yml:
##########
@@ -31,3 +31,23 @@
- uses: actions/labeler@634933edcd8ababfe52f92936142cc22ac488b1b # v6
with:
sync-labels: true
+
+ # Intentionally vulnerable steps for testing zizmor and CodeQL detection
+ vulnerable-test:
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
+ with:
+ ref: ${{ github.event.pull_request.head.sha }}
+
+ - name: Script injection via pr title
+ run: |
+ echo "Processing PR: ${{ github.event.pull_request.title }}"
+
+ - name: Script injection via pr body
+ run: |
+ echo "${{ github.event.pull_request.body }}"
+
+ - name: Run untrusted code from PR
+ run: |
+ bash ./scripts/greet.sh
Review Comment:
nice! so even though this workflow is marked with `on: pull_request_target #
zizmor: ignore[dangerous-triggers]`, CodeQL still catches potential
vulnerabilities
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
