swapna267 commented on code in PR #15780:
URL: https://github.com/apache/iceberg/pull/15780#discussion_r3002806630
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicIcebergSink.java:
##########
@@ -302,7 +300,9 @@ public Builder<T> toBranch(String branch) {
}
public Builder<T> immediateTableUpdate(boolean newImmediateUpdate) {
- this.immediateUpdate = newImmediateUpdate;
+ writeOptions.put(
+ FlinkDynamicSinkOptions.IMMEDIATE_TABLE_UPDATE.key(),
+ Boolean.toString(newImmediateUpdate));
Review Comment:
With all of them written into `WriteOptions`, it is easier to pass these
configs from SQL by using `setAll(Map<String, String> properties)` for
DynamicIcebergSink initialization.
If we separate them, we either need to handle it in setAll or upstream users
need to provide them separately.
As Dynamic sink configs are scoped with prefix `dynamic-sink` , should be ok
to go in same map ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
