RussellSpitzer opened a new pull request, #15798: URL: https://github.com/apache/iceberg/pull/15798
Discovered when fixing - #15634 Previously this wasn't an issue because the validation table was close enough to the tables being tested that everything worked out. Parquet manifests changed the structure for partitioned vs unpartitioned tables, the validation table was partitioned so validation began to fail. ---- Three test methods in TestReplacePartitions operate on separate unpartitioned or all-void tables but were passing the wrong table instance to commit() and validation helpers: - testReplaceWithUnpartitionedTable used commit(table, ...) instead of commit(unpartitioned, ...) for operations on the unpartitioned table - testReplaceAndMergeWithUnpartitionedTable had the same issue - validateSnapshot and validateManifestEntries were called without specifying which table to use for reading manifests, defaulting to the partitioned test table instead of the actual target table The commit(table, ...) bug was introduced in #6650 when the test was refactored from direct toBranch().commit() calls to use the commit() helper. The validation calls for the all-void unpartitioned table (added in #14186) also used the default overloads that read manifests via the wrong table's specs. This adds Table-accepting overloads for validateSnapshot and validateManifestEntries in TestBase and updates the affected tests to pass the correct table instance. Cursor + Claude-4.6-opus-high -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
