CTTY commented on code in PR #2288:
URL: https://github.com/apache/iceberg-rust/pull/2288#discussion_r3003484196
##########
crates/iceberg/src/compression.rs:
##########
@@ -49,13 +94,17 @@ impl CompressionCodec {
ErrorKind::FeatureUnsupported,
"LZ4 decompression is not supported currently",
)),
- CompressionCodec::Zstd =>
Ok(zstd::stream::decode_all(&bytes[..])?),
- CompressionCodec::Gzip => {
+ CompressionCodec::Zstd(_) =>
Ok(zstd::stream::decode_all(&bytes[..])?),
+ CompressionCodec::Gzip(_) => {
let mut decoder = GzDecoder::new(&bytes[..]);
let mut decompressed = Vec::new();
decoder.read_to_end(&mut decompressed)?;
Ok(decompressed)
}
+ CompressionCodec::Snappy => Err(Error::new(
+ ErrorKind::FeatureUnsupported,
+ "Snappy decompression is not supported currently",
+ )),
Review Comment:
This makes sense
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
