openinx commented on a change in pull request #1822:
URL: https://github.com/apache/iceberg/pull/1822#discussion_r533197314
##########
File path:
flink/src/main/java/org/apache/iceberg/flink/source/FlinkInputFormat.java
##########
@@ -48,6 +48,8 @@
private final ScanContext context;
private transient RowDataIterator iterator;
+ private transient long currentReadCount = 0L;
+ private transient long limit;
Review comment:
How about just using the `context.limit()` in `reachedEnd`, rather than
introducing another new transient field `limit` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
