laskoviymishka commented on code in PR #735:
URL: https://github.com/apache/iceberg-go/pull/735#discussion_r3005528905
##########
table/arrow_scanner.go:
##########
@@ -513,6 +598,17 @@ func (as *arrowScan) recordsFromTask(ctx context.Context,
task internal.Enumerat
return ToRequestedSchema(ctx, as.projectedSchema, iceSchema, r,
false, false, as.useLargeTypes)
})
+ // Row lineage (v3): fill _row_id and _last_updated_sequence_number
from task constants when in projection.
+ if task.Value.FirstRowID != nil || task.Value.DataSequenceNumber != nil
{
+ var rowOffset int64
+ taskVal := task.Value
+ pipeline = append(pipeline, func(r arrow.RecordBatch)
(arrow.RecordBatch, error) {
+ defer r.Release()
+
+ return synthesizeRowLineageColumns(ctx, &rowOffset,
taskVal, r)
Review Comment:
These are metadata columns, so only synthesized when present in the
projection.
In other word - column's presence in the projection IS the toggle
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
