RussellSpitzer commented on code in PR #15822: URL: https://github.com/apache/iceberg/pull/15822#discussion_r3007497959
########## AGENTS.md: ########## @@ -159,6 +159,7 @@ The `api/` module has the strongest stability guarantees — breaking changes ar - One concern per PR. Unrelated whitespace, import, or formatting changes go in separate PRs. - Keep first version of a PR minimal — defer recovery, optimization, and edge cases to follow-ups. - Commit messages describe the *what* and *why*, not implementation details. +- Before creating or amending a commit, run the relevant code style check and fix any violations. Review Comment: This should be a pre commit hook, I feel like adding it here is applying an agent in an inefficient way. I can post an example pre commit hook if people like, but it's much better imho to phase a precommit that just runs spotless apply and restages -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
