geruh commented on code in PR #3215:
URL: https://github.com/apache/iceberg-python/pull/3215#discussion_r3017009775
##########
.github/workflows/pypi-build-artifacts.yml:
##########
@@ -56,6 +56,7 @@ jobs:
uses: astral-sh/setup-uv@5a095e7a2014a4212f075830d4f7277575a9d098 #
v7.3.1
- name: Set version with RC
+ shell: bash
Review Comment:
Technically `shell: bash` isn't needed here — `uv version "$VERSION"` uses
the shell env var, but `${{ env.VERSION }}` is a GitHub Actions expression that
gets interpolated by the runner _before_ the shell sees it, so it works on any
shell including PowerShell. That said, keeping `shell: bash` is fine as a
defensive measure and signals intent for cross-platform consistency.
##########
.github/workflows/nightly-pypi-build.yml:
##########
@@ -55,6 +55,7 @@ jobs:
- name: Debug version
run: echo "Publishing version ${STEPS_SET_VERSION_OUTPUTS_VERSION}"
+ shell: bash
Review Comment:
nit: `shell: bash` is added here but the `run` command uses
`${STEPS_SET_VERSION_OUTPUTS_VERSION}` which is a shell env var — so this is
correct. However it'd be more consistent to place `shell:` _before_ `env:`
(matching the ordering in the other two files in this PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
