dttung2905 commented on code in PR #30:
URL: https://github.com/apache/iceberg-terraform/pull/30#discussion_r3017044223
##########
internal/provider/resource_namespace.go:
##########
@@ -408,3 +409,16 @@ func (r *icebergNamespaceResource) Delete(ctx
context.Context, req resource.Dele
return
}
}
+
+func (r *icebergNamespaceResource) ImportState(ctx context.Context, req
resource.ImportStateRequest, resp *resource.ImportStateResponse) {
+ resource.ImportStatePassthroughID(ctx, path.Root("id"), req, resp)
+
+ nameParts := strings.Split(req.ID, ".")
Review Comment:
What if the user wrongly input something like `<parent-ns>..<child-ns>` ?
Should we do a check for empty segment ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
