stevenzwu commented on code in PR #15500:
URL: https://github.com/apache/iceberg/pull/15500#discussion_r3018196997
##########
core/src/main/java/org/apache/iceberg/rest/auth/TLSConfigurer.java:
##########
@@ -32,6 +33,10 @@ default SSLContext sslContext() {
return SSLContexts.createDefault();
}
+ default HostnameVerificationPolicy hostnameVerificationPolicy() {
+ return HostnameVerificationPolicy.CLIENT;
+ }
+
default HostnameVerifier hostnameVerifier() {
Review Comment:
> I want to stress though that returning null instead of
HttpsSupport.getDefaultHostnameVerifier() here is a behavioral change.
Not really a behavior change btw 1.10 and 1.11 since the original change
from Bryant hasn't been released it.
And returning null is essentially the same as using the default built-in
hostname verifier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
