pvary commented on a change in pull request #1840:
URL: https://github.com/apache/iceberg/pull/1840#discussion_r533575304
##########
File path: mr/src/test/java/org/apache/iceberg/mr/hive/TestTables.java
##########
@@ -83,12 +92,107 @@ public Tables tables() {
public abstract String locationForCreateTableSQL(TableIdentifier identifier);
/**
- * If the {@link Catalogs#LOCATION} is needed for {@link
Catalogs#loadTable(Configuration, Properties)} then this
- * method should provide the location string. It should return
<code>null</code> if the location is not needed.
- * @param identifier The table identifier
- * @return The location string for loadTable operation
+ * If creating the Hive table independently is needed for the given Catalog
then this should return the Hive SQL
+ * string which is needed to be executed.
+ * @param identifier The table identifier (the namespace should be "default")
+ * @return The SQL string - which should be executed, null - if it is not
needed.
+ */
+ public String createHiveTableSQL(TableIdentifier identifier) {
+ return String.format("CREATE TABLE default.%s STORED BY '%s' %s",
identifier.name(),
Review comment:
Added the possibility
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
