zeroshade commented on code in PR #29:
URL: https://github.com/apache/iceberg-terraform/pull/29#discussion_r3018128015
##########
internal/provider/table_schema.go:
##########
@@ -392,16 +427,17 @@ func (s *icebergTableSchemaFieldStructProperties)
UnmarshalJSON(b []byte) error
func marshalFieldJSON(id types.Int64, name, typeStr string, required bool, doc
*string, listProps, mapProps, structProps interface{}) ([]byte, error) {
type Field struct {
- ID int64 `json:"id"`
+ ID *int64 `json:"id,omitempty"`
Review Comment:
isn't the ID required?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
