RussellSpitzer commented on code in PR #15670:
URL: https://github.com/apache/iceberg/pull/15670#discussion_r3018596250
##########
spark/v4.1/spark/src/main/java/org/apache/iceberg/spark/source/AsyncSparkMicroBatchPlanner.java:
##########
@@ -293,8 +295,10 @@ private StreamingOffset computeLimitedOffset(ReadLimit
limit) {
queuedFileCount.get(),
queuedRowCount.get());
- // Convert to list for indexed access
List<Pair<StreamingOffset, FileScanTask>> queueList =
Lists.newArrayList(queue);
Review Comment:
I would probably rename this something like "queueSnapshot" since we are
basically trying to extract a point in time view of the queue, the indexing
isn't important any more (or the list type)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
