mkaravel commented on code in PR #15834: URL: https://github.com/apache/iceberg/pull/15834#discussion_r3018590630
########## format/spec.md: ########## @@ -242,10 +242,12 @@ For `geometry` type, the CRS does not affect geometric calculations, which are a The default CRS value `OGC:CRS84` means that the objects must be stored in longitude, latitude based on the WGS84 datum. -Custom CRS values can be specified by a string of the format `type:identifier`, where `type` is one of the following values: - -* `srid`: [Spatial reference identifier](https://en.wikipedia.org/wiki/Spatial_reference_system#Identifier), `identifier` is the SRID itself. -* `projjson`: [PROJJSON](https://proj.org/en/stable/specifications/projjson.html), `identifier` is the name of a table property where the projjson string is stored. +Non-defaullt CRS values are specified by any string that uniquely identifies coordinate reference system associated with this type. +To maximize interoperability suggested (but not limited to) formats for CRS are: +* `authorithy:identifier` - where `authorithy` represents some well known authorities - examples are `OGC:CRS84`, `OGC:CRS83`, `OGC:CRS27`. Review Comment: ```suggestion * `authority:code` - where `authority` represents some well known authorities, and `code` is the code used by the authority to identify the CRS - examples are `OGC:CRS84`, `OGC:CRS83`, `OGC:CRS27`, `ESPG:3857`, or `ESRI:37000`. See [https://spatialreference.org/](https://spatialreference.org/) for definitions coordinate reference systems provided by some well known authorities. ``` ########## format/spec.md: ########## @@ -242,10 +242,12 @@ For `geometry` type, the CRS does not affect geometric calculations, which are a The default CRS value `OGC:CRS84` means that the objects must be stored in longitude, latitude based on the WGS84 datum. -Custom CRS values can be specified by a string of the format `type:identifier`, where `type` is one of the following values: - -* `srid`: [Spatial reference identifier](https://en.wikipedia.org/wiki/Spatial_reference_system#Identifier), `identifier` is the SRID itself. -* `projjson`: [PROJJSON](https://proj.org/en/stable/specifications/projjson.html), `identifier` is the name of a table property where the projjson string is stored. +Non-defaullt CRS values are specified by any string that uniquely identifies coordinate reference system associated with this type. +To maximize interoperability suggested (but not limited to) formats for CRS are: Review Comment: I would also something about all descriptions being case-insensitive. ########## format/spec.md: ########## @@ -242,10 +242,12 @@ For `geometry` type, the CRS does not affect geometric calculations, which are a The default CRS value `OGC:CRS84` means that the objects must be stored in longitude, latitude based on the WGS84 datum. -Custom CRS values can be specified by a string of the format `type:identifier`, where `type` is one of the following values: - -* `srid`: [Spatial reference identifier](https://en.wikipedia.org/wiki/Spatial_reference_system#Identifier), `identifier` is the SRID itself. -* `projjson`: [PROJJSON](https://proj.org/en/stable/specifications/projjson.html), `identifier` is the name of a table property where the projjson string is stored. +Non-defaullt CRS values are specified by any string that uniquely identifies coordinate reference system associated with this type. +To maximize interoperability suggested (but not limited to) formats for CRS are: +* `authorithy:identifier` - where `authorithy` represents some well known authorities - examples are `OGC:CRS84`, `OGC:CRS83`, `OGC:CRS27`. +* `inlined_projjson` - Inlining whole CRS definition in [PROJJSON](https://proj.org/en/stable/specifications/projjson.html) format. Review Comment: It might make sense to add an example for this one as well. How about the one for `OGC:CRS83`? ########## format/spec.md: ########## @@ -242,10 +242,12 @@ For `geometry` type, the CRS does not affect geometric calculations, which are a The default CRS value `OGC:CRS84` means that the objects must be stored in longitude, latitude based on the WGS84 datum. -Custom CRS values can be specified by a string of the format `type:identifier`, where `type` is one of the following values: - -* `srid`: [Spatial reference identifier](https://en.wikipedia.org/wiki/Spatial_reference_system#Identifier), `identifier` is the SRID itself. -* `projjson`: [PROJJSON](https://proj.org/en/stable/specifications/projjson.html), `identifier` is the name of a table property where the projjson string is stored. +Non-defaullt CRS values are specified by any string that uniquely identifies coordinate reference system associated with this type. +To maximize interoperability suggested (but not limited to) formats for CRS are: +* `authorithy:identifier` - where `authorithy` represents some well known authorities - examples are `OGC:CRS84`, `OGC:CRS83`, `OGC:CRS27`. +* `inlined_projjson` - Inlining whole CRS definition in [PROJJSON](https://proj.org/en/stable/specifications/projjson.html) format. +* `srid:identifier` - [SRID - Spatial reference identifier](https://en.wikipedia.org/wiki/Spatial_reference_system#Identifier), `identifier` is the SRID itself. +* `projjson:table_property_name` - where `table_property_name` is the name of a table property where the projjson string is stored. Review Comment: +1 on the description for `srid:identifier` that @uros-db is suggesting. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
