mbutrovich commented on PR #2301: URL: https://github.com/apache/iceberg-rust/pull/2301#issuecomment-4170784361
Rewrote using `ArrowSchemaVisitor`, following the same pattern as `MetadataStripVisitor`. The visitor walks the Arrow schema and at each primitive, checks if it's `Timestamp(Nanosecond)` and looks up the Iceberg field by ID to determine the target resolution. This also eliminates the `parquet_schema` parameter entirely — we no longer need Parquet column paths to find INT96 columns, since arrow-rs only produces `Timestamp(Nanosecond)` for INT96 (INT64 timestamps get the correct unit from Parquet metadata). Made `visit_schema` `pub(crate)` so it's accessible from `reader.rs`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
