rdblue commented on code in PR #15630: URL: https://github.com/apache/iceberg/pull/15630#discussion_r3024943235
########## format/spec.md: ########## @@ -134,6 +178,8 @@ Tables do not require rename, except for tables that use atomic rename to implem * **Manifest** -- A file that lists data or delete files; a subset of a snapshot. * **Data file** -- A file that contains rows of a table. * **Delete file** -- A file that encodes rows of a table that are deleted by position or data values. +* **Absolute path** -- A path string that includes a URI scheme and can be used directly. Review Comment: I think this is a good idea since schemes are very strict in the spec: https://datatracker.ietf.org/doc/html/rfc3986#section-3.1 > URI = scheme ":" hier-part [ "?" query ] [ "#" fragment ] > scheme = ALPHA *( ALPHA / DIGIT / "+" / "-" / "." ) That makes it clear what a scheme can consist of and that it is terminated by `:`. This requirement that a location/path is absolute if and only if it contains a scheme is a good one and helped by the link. ########## format/spec.md: ########## @@ -134,6 +178,8 @@ Tables do not require rename, except for tables that use atomic rename to implem * **Manifest** -- A file that lists data or delete files; a subset of a snapshot. * **Data file** -- A file that contains rows of a table. * **Delete file** -- A file that encodes rows of a table that are deleted by position or data values. +* **Absolute path** -- A path string that includes a URI scheme and can be used directly. Review Comment: I think this is a good idea since schemes are very strict in the spec: https://datatracker.ietf.org/doc/html/rfc3986#section-3.1 > URI = scheme ":" hier-part [ "?" query ] [ "#" fragment ] > scheme = ALPHA *( ALPHA / DIGIT / "+" / "-" / "." ) That makes it clear what a scheme can consist of and that it is terminated by `:`. This requirement that a location/path is absolute if and only if it contains a scheme is a good one and is helped by the link. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
