RussellSpitzer commented on code in PR #15590: URL: https://github.com/apache/iceberg/pull/15590#discussion_r3034282639
########## core/src/main/java/org/apache/iceberg/DataFileAccumulator.java: ########## @@ -0,0 +1,134 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg; + +import java.util.Collection; +import java.util.Collections; +import java.util.List; +import java.util.Map; +import java.util.Set; +import java.util.function.BiFunction; +import java.util.function.Consumer; +import java.util.function.Function; +import org.apache.iceberg.io.CloseableIterable; +import org.apache.iceberg.relocated.com.google.common.base.Preconditions; +import org.apache.iceberg.relocated.com.google.common.collect.Iterables; +import org.apache.iceberg.relocated.com.google.common.collect.Lists; +import org.apache.iceberg.relocated.com.google.common.collect.Maps; +import org.apache.iceberg.relocated.com.google.common.collect.Sets; +import org.apache.iceberg.util.DataFileSet; + +/** Accumulates data files and flushes them to manifests when a count threshold is reached. */ +class DataFileAccumulator { + + static final int DEFAULT_FLUSH_THRESHOLD = 100_000; Review Comment: 100k is a pretty big number, I agree this should probably be dynamic based on manifest target file size . It my recent benchmarks I have some ratios I was working with based on the number of metric columns. I found that 300,000 / num Columns = rows in 8mb which worked out to about 30 bytes per column we are storing metrics fore. So you could use something like flushThreshold = targetManifestSizeBytes / (30 * numCols) Not sure but I feel like we have to be a little careful here about not just writing a bunch of tiny flushes for each big flush. Like if I flush 1.01 manifests worth of file entries I will get 1 full size manifest and a 0.01 percent full manifest. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
