rdblue commented on a change in pull request #1839:
URL: https://github.com/apache/iceberg/pull/1839#discussion_r533759873
##########
File path: hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java
##########
@@ -168,6 +168,7 @@ public boolean dropTable(TableIdentifier identifier,
boolean purge) {
if (purge && lastMetadata != null) {
CatalogUtil.dropTableData(ops.io(), lastMetadata);
+ CatalogUtil.dropTableBaseLocation(ops.io(), lastMetadata.location());
Review comment:
I don't think this should be the default behavior. It is fine if people
want to do this in catalogs, but I would prefer to have an option to turn it on
or off.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
