anoopj commented on code in PR #15883:
URL: https://github.com/apache/iceberg/pull/15883#discussion_r3042314328
##########
api/src/main/java/org/apache/iceberg/expressions/StrictMetricsEvaluator.java:
##########
@@ -467,8 +469,36 @@ public <T> Boolean startsWith(BoundReference<T> ref,
Literal<T> lit) {
@Override
public <T> Boolean notStartsWith(BoundReference<T> ref, Literal<T> lit) {
- // TODO: Handle cases that definitely cannot match, such as
notStartsWith("x") when the bounds
- // are ["a", "b"].
+ int id = ref.fieldId();
+ if (isNestedColumn(id)) {
Review Comment:
Consider adding a test for nested column?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
