barry3406 commented on PR #15917: URL: https://github.com/apache/iceberg/pull/15917#issuecomment-4222036075
Verified the precedence list against `SparkWriteBuilder` (the source quoted in #15916) and the wording matches the actual logic. One small thing — since this is the second time the doc has drifted from the code (first was after #15288), might be worth a one-line `<!-- KEEP IN SYNC: SparkWriteBuilder.branchOption -->` HTML comment near the precedence list so the next person touching that code path remembers to update the docs. Optional — the change as it stands is already correct. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
