barry3406 commented on code in PR #15926:
URL: https://github.com/apache/iceberg/pull/15926#discussion_r3067694057
##########
api/src/main/java/org/apache/iceberg/io/FileRange.java:
##########
@@ -31,10 +31,8 @@ public class FileRange {
public FileRange(CompletableFuture<ByteBuffer> byteBuffer, long offset, int
length)
throws EOFException {
Review Comment:
good catch — you're right, nothing in the constructor throws that. it was
leftover from the original file. dropped the `throws` and cleaned up the
unreachable try/catch in `ParquetIO.convertRanges` in 8ffa366.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
