swapna267 commented on PR #15884: URL: https://github.com/apache/iceberg/pull/15884#issuecomment-4232773178
Thanks @shanzi . Change LGTM. I think it would makes sense to add an integration test similar to , https://github.com/apache/iceberg/blob/main/flink/v2.1/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSourceWithWatermarkExtractor.java#L99 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
