spr0els commented on code in PR #3224:
URL: https://github.com/apache/iceberg-python/pull/3224#discussion_r3071674422
##########
tests/catalog/test_rest.py:
##########
@@ -1416,6 +1417,38 @@ def test_create_view_409(
assert "View already exists" in str(e.value)
+def test_load_view_200(rest_mock: Mocker, example_view_metadata_rest_json:
dict[str, Any]) -> None:
+ rest_mock.get(
+ f"{TEST_URI}v1/namespaces/fokko/views/view",
+ json=example_view_metadata_rest_json,
+ status_code=200,
+ request_headers=TEST_HEADERS,
+ )
+ catalog = RestCatalog("rest", uri=TEST_URI, token=TEST_TOKEN)
+ actual = catalog.load_view(("fokko", "view"))
+ expected = View(identifier=("fokko", "view"),
metadata=ViewMetadata(**example_view_metadata_rest_json["metadata"]))
+ assert actual == expected
+
+
+def test_load_view_404(rest_mock: Mocker) -> None:
Review Comment:
Correct me if I'm wrong, but isn't this case already covered with the
`test_load_view_404` test?
If no view with the same identifier as the table identifier is found in the
warehouse, this would be the same case as loading a non existent view.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
