pvary commented on a change in pull request #1854:
URL: https://github.com/apache/iceberg/pull/1854#discussion_r534325668
##########
File path:
mr/src/main/java/org/apache/iceberg/mr/hive/serde/objectinspector/IcebergTimestampObjectInspector.java
##########
@@ -22,26 +22,38 @@
import java.sql.Timestamp;
import java.time.LocalDateTime;
import java.time.OffsetDateTime;
+import java.time.ZoneId;
import org.apache.hadoop.hive.serde2.io.TimestampWritable;
import
org.apache.hadoop.hive.serde2.objectinspector.primitive.AbstractPrimitiveJavaObjectInspector;
import
org.apache.hadoop.hive.serde2.objectinspector.primitive.TimestampObjectInspector;
import org.apache.hadoop.hive.serde2.typeinfo.TypeInfoFactory;
public abstract class IcebergTimestampObjectInspector extends
AbstractPrimitiveJavaObjectInspector
- implements
TimestampObjectInspector {
+ implements TimestampObjectInspector, IcebergWriteObjectInspector {
private static final IcebergTimestampObjectInspector INSTANCE_WITH_ZONE =
new IcebergTimestampObjectInspector() {
@Override
LocalDateTime toLocalDateTime(Object o) {
return ((OffsetDateTime) o).toLocalDateTime();
}
+
+ @Override
+ public Object getIcebergObject(Object o) {
Review comment:
Fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
