zeroshade commented on code in PR #867:
URL: https://github.com/apache/iceberg-go/pull/867#discussion_r3074331158
##########
table/transaction.go:
##########
@@ -420,7 +414,7 @@ func (t *Transaction) ReplaceDataFiles(ctx context.Context,
filesToDelete, files
}
commitUUID := uuid.New()
- updater := t.updateSnapshot(fs, snapshotProps,
OpOverwrite).mergeOverwrite(&commitUUID)
+ updater := t.updateSnapshot(fs, snapshotProps,
OpReplace).mergeOverwrite(&commitUUID)
Review Comment:
we can only use `OpReplace` here instead of `OpOverwrite` if there are no
changes to the underlying data. We should probably validate this before we use
OpReplace instead of OpOverwrite, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
