dejii commented on code in PR #15968:
URL: https://github.com/apache/iceberg/pull/15968#discussion_r3086796051
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##########
@@ -824,11 +832,7 @@ protected Map<String, String> properties() {
@Override
public void close() throws IOException {
- super.close();
Review Comment:
I'll add `super.close()` back. I was following the existing pattern across
other catalogs -- none of them call `super.close()`
([HadoopCatalog#L124](https://github.com/apache/iceberg/blob/56092bc8cbfa19380cdd4513fc707c6d97ef8e36/core/src/main/java/org/apache/iceberg/hadoop/HadoopCatalog.java#L124),
[JdbcCatalog#L154](https://github.com/apache/iceberg/blob/56092bc8cbfa19380cdd4513fc707c6d97ef8e36/core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java#L154),
[GlueCatalog#L197](https://github.com/apache/iceberg/blob/56092bc8cbfa19380cdd4513fc707c6d97ef8e36/aws/src/main/java/org/apache/iceberg/aws/glue/GlueCatalog.java#L197),
[NessieCatalog#L179](https://github.com/apache/iceberg/blob/56092bc8cbfa19380cdd4513fc707c6d97ef8e36/nessie/src/main/java/org/apache/iceberg/nessie/NessieCatalog.java#L179),
[DynamoDbCatalog#L145](https://github.com/apache/iceberg/blob/56092bc8cbfa19380cdd4513fc707c6d97ef8e36/aws/src/main/java/org/apache/iceberg/aws/dynamodb/DynamoDbCatalog.java#L145),
[EcsC
atalog#L113](https://github.com/apache/iceberg/blob/56092bc8cbfa19380cdd4513fc707c6d97ef8e36/dell/src/main/java/org/apache/iceberg/dell/ecs/EcsCatalog.java#L113)),
they all register `metricsReporter()` in their own closeableGroup instead. But
agree it's better to be future-proof here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
