rdblue commented on a change in pull request #1862:
URL: https://github.com/apache/iceberg/pull/1862#discussion_r535539404
##########
File path: spark3/src/main/java/org/apache/iceberg/spark/source/SparkTable.java
##########
@@ -160,6 +167,43 @@ public WriteBuilder newWriteBuilder(LogicalWriteInfo info)
{
return new SparkWriteBuilder(sparkSession(), icebergTable, info);
}
+ @Override
+ public MergeBuilder newMergeBuilder(LogicalWriteInfo info) {
Review comment:
I like that this is used for both MERGE and DELETE without needing to
customize, so I'm reluctant to do too much here. It is close, but I think I
would opt to have a single config property.
Operation is something that we could pass through `LogicalWriteInfo` in the
future for better logging and purposes like this one. For now, we could add the
operation as a String passed to `newMergeBuilder`, but there is no guarantee
that we would add this to `LogicalWriteInfo` later. I think that means that we
should go for a single property and we can customize later if we do get the
operation when the builder is created.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
