aokolnychyi edited a comment on pull request #1873: URL: https://github.com/apache/iceberg/pull/1873#issuecomment-738705947
This change looks great to me, just minor comments in addition to what @pvary mentioned. Thanks for working on this, @raptond! We could add fewer configs but I'd be in favor of what this PR does. It was really painful when we hit this problem and couldn't do anything without changing the code so having props to configure every aspect sounds good to me. It is rather a sensitive area and more control here seems justified to me. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
