afeldman1 commented on code in PR #3299:
URL: https://github.com/apache/iceberg-python/pull/3299#discussion_r3174303337
##########
.github/workflows/python-ci.yml:
##########
@@ -97,6 +97,8 @@ jobs:
run: make install
- name: Run integration tests with coverage
run: COVERAGE=1 make test-integration
+ env:
+ RAY_ENABLE_UV_RUN_RUNTIME_ENV: "0"
Review Comment:
I actually tried that initially, but it cannot be done because the ray uv
hook looks at the parent uv run process, including the env vars, at it's import
time. So by the time it gets to the `ray_session` test fixture and does the
`ray.init()`, the new env var is not refreshed to be picked up.
I tested using the same commands (`PYTHON=3.14 make test` : `PYTHON=3.14
RAY_ENABLE_UV_RUN_RUNTIME_ENV=0 make test-integration`) that you mentioned, and
something to keep in mind for next is that including them in the pr description
would be helpful.
What we can do is remove this change in python-ci.yml and make the following
change instead
https://github.com/apache/iceberg-python/blob/main/Makefile#L118
`RAY_ENABLE_UV_RUN_RUNTIME_ENV=0 $(TEST_RUNNER) pytest tests/ -m integration
$(PYTEST_ARGS)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
