Guosmilesmile commented on code in PR #15776:
URL: https://github.com/apache/iceberg/pull/15776#discussion_r3180896143
##########
orc/src/main/java/org/apache/iceberg/orc/OrcValueReaders.java:
##########
@@ -163,6 +177,121 @@ protected StructReader(
}
}
+ protected StructReader(
Review Comment:
No, it won't. With the current changes, if the old constructor is used, the
original behavior is preserved, and the new constructor has the new behavior.
If that's the case, wouldn't it be better to not add Deprecated, but instead
write proper Javadoc and let the caller choose based on their own scenario?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
