tanmayrauth commented on PR #975: URL: https://github.com/apache/iceberg-go/pull/975#issuecomment-4372340328
Thanks for the review! Addressed all the feedback, extracted resolveUsePathStyle(endpoint, props) as a helper with table tests covering the default, override, and edge cases. Replaced the raw "client.region" string with an S3ClientRegion constant in io/config.go. Gated the SigV4 region fallback to only s3 and s3tables services, and folded it into the existing enableSigv4 block with a softened "best-effort fallback" comment. No changelog file exists in the repo so I've added a breaking-change note to the PR description instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
