CTTY commented on code in PR #2401:
URL: https://github.com/apache/iceberg-rust/pull/2401#discussion_r3185197583
##########
crates/storage/opendal/tests/file_io_s3_test.rs:
##########
@@ -199,8 +204,8 @@ mod tests {
),
Err(e) => {
assert!(
- e.to_string()
- .contains("no valid credential found and anonymous
access is not allowed")
+ e.to_string().contains("credential"),
Review Comment:
I assume the error message changed?
If so, can we loosen the string check a bit less?
##########
crates/storage/opendal/Cargo.toml:
##########
@@ -54,6 +54,7 @@ futures = { workspace = true }
[dev-dependencies]
async-trait = { workspace = true }
iceberg_test_utils = { path = "../../test_utils", features = ["tests"] }
-reqsign = { version = "0.16.3", default-features = false }
+reqsign-aws-v4 = { version = "3.0.0" }
Review Comment:
Do we really need this? it's already defined in the `dependencies` section,
and tests that need this dependency should be gated by `opendal-s3` feature flag
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
