zeroshade commented on code in PR #985:
URL: https://github.com/apache/iceberg-go/pull/985#discussion_r3189524856
##########
manifest.go:
##########
@@ -751,33 +776,54 @@ func (c *ManifestReader) ReadEntry() (ManifestEntry,
error) {
return tmp, nil
}
+// IterManifest returns an iterator that streams manifest entries from
+// the provided reader without buffering them. If discardDeleted is true,
+// entries whose status is "deleted" are skipped.
+func IterManifest(m ManifestFile, f io.Reader, discardDeleted bool)
iter.Seq2[ManifestEntry, error] {
Review Comment:
agreed, there's no reason to export both this AND have the `Entries` method
on the manifest file itself. What's the purpose of this vs just opening the
manifest directly to get a `ManifestFile` and then just calling `Entries(fs,
discard)` on it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
