laskoviymishka opened a new issue, #996: URL: https://github.com/apache/iceberg-go/issues/996
Parent: #589 Depends on #866 (DV bitmap reader). PR #855 already classifies DV files in scan planning behind an `ErrNotImplemented` guard, and #866 adds the `RoaringPositionBitmap` codec + Puffin `deletion-vector-v1` blob support. This issue is the integration: wire `ReadDV` into `readAllDeleteFiles` in `table/arrow_scanner.go` so DV positions merge into the existing position-delete pipeline. The rest of the scanner doesn't need to know whether a delete came from a Parquet position-delete file or a Puffin DV — both surface as positions. Remove the `ErrNotImplemented` guard added in #855 once the merge works. A mixed-case test belongs here too: same data file with both a DV and a Parquet position-delete — Java's behavior is "DV wins"; mirror that. End-to-end coverage: write data → write a puffin DV referencing those positions → scan → assert deleted rows are filtered. Spec: [Iceberg deletion vectors](https://iceberg.apache.org/spec/#deletion-vectors). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
