laskoviymishka opened a new issue, #1014: URL: https://github.com/apache/iceberg-go/issues/1014
Parent: #830 After PR #934, `snapshotProducer.commit()` appends a `validate` closure to `txn.validators` for every producer, including `fastAppendFiles` and `mergeAppendFiles` whose `validate()` is a deliberate no-op. Long transactions (multi-step `Append` + `Overwrite` chains) accumulate O(N) no-op closures, all of which run at final `doCommit`. Cheap per call, but wasteful and noisy in profiles. Add a small interface method to `producerImpl`, something like `needsValidation() bool`. Default to `true`; have `fastAppendFiles` and `mergeAppendFiles` return `false`. Skip the validator registration in `snapshotProducer.commit()` when `needsValidation()` is false. The no-op `validate` methods can stay as belt-and-suspenders or be removed once the registration is gated. Lock the behavior with a small unit test that asserts a fast-append commit leaves `txn.validators` empty. Flagged as a smell in #928's round-1 review and deferred — landing it now makes the validator slice trustworthy as a registration surface. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
