openinx commented on a change in pull request #1867:
URL: https://github.com/apache/iceberg/pull/1867#discussion_r537224496
##########
File path:
flink/src/main/java/org/apache/iceberg/flink/sink/IcebergStreamWriter.java
##########
@@ -62,7 +62,7 @@ public void open() {
@Override
public void prepareSnapshotPreBarrier(long checkpointId) throws Exception {
// close all open files and emit files to downstream committer operator
- for (DataFile dataFile : writer.complete()) {
+ for (DataFile dataFile : writer.complete().dataFiles()) {
Review comment:
I like the idea about introducing a new `dataFiles` in `TaskWriter`
rather than precondition check everywhere.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
