wgtmac commented on code in PR #633: URL: https://github.com/apache/iceberg-cpp/pull/633#discussion_r3193254315
########## src/iceberg/util/retry_util.h: ########## Review Comment: Keeping this as-is for now. `RetryRunner` currently preserves the existing contract of returning the error from the attempt that caused retrying to stop. Recording every failed attempt would require separate error aggregation or metrics reporting; the existing TODO on `Run` points toward using a metrics reporter once available. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
